Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify all Kani attributes in all crate items upfront #2536

Merged
merged 4 commits into from
Jun 19, 2023

Conversation

celinval
Copy link
Contributor

Description of changes:

The Kani attributes were being lazily evaluated in some cases. We have also been handling duplicated attribute inconsistently.

Instead, validate all the attributes upfront and print all the errors found. Also, for all attributes that multiple occurrences is redundant, we emit an error if user provides 2 or more.

Resolved issues:

N/A

Related RFC:

Call-outs:

Leaving this as a draft until we merge #2534

Testing:

  • How is this change tested? Existing + new tests

  • Is this a refactor change?

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@celinval celinval marked this pull request as ready for review June 16, 2023 19:48
@celinval celinval requested a review from a team as a code owner June 16, 2023 19:48
@zhassan-aws
Copy link
Contributor

Should this be marked as a resolver for #2530?

@celinval celinval linked an issue Jun 17, 2023 that may be closed by this pull request
@celinval celinval enabled auto-merge (squash) June 19, 2023 18:50
@celinval celinval merged commit 49405b2 into model-checking:main Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure on cargo-ui/unstable-attr/invalid regression
2 participants