Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for sysconf #2557

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Adds support for sysconf #2557

merged 2 commits into from
Jul 25, 2023

Conversation

feliperodri
Copy link
Contributor

Description of changes:

Adds support for sysconf.

Resolved issues:

Unblock customer.

Testing:

  • How is this change tested? Regression test.

  • Is this a refactor change? No.

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@feliperodri feliperodri self-assigned this Jun 22, 2023
celinval
celinval approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

celinval
celinval reviewed Jun 22, 2023
View reviewed changes
Copy link
Contributor

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments on the test. :)

tests/kani/Intrinsics/Sysconf/main.rs Outdated Show resolved Hide resolved
tests/kani/Intrinsics/Sysconf/main.rs Outdated Show resolved Hide resolved
@feliperodri
Copy link
Contributor Author

#2614 will unblock this PR (we will have access to the new model for sysconf in CBMC).

@feliperodri feliperodri marked this pull request as ready for review July 25, 2023 19:00
@feliperodri feliperodri requested a review from a team as a code owner July 25, 2023 19:00
@feliperodri feliperodri enabled auto-merge (squash) July 25, 2023 19:00
@feliperodri
Adds long int tothe list of C types
555a8b2 
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
@feliperodri
Adds sysconf to the list of supported builtins
176ac64 
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
@feliperodri feliperodri merged commit 319d859 into model-checking:main Jul 25, 2023
12 checks passed
@feliperodri feliperodri deleted the sysconf-support branch July 26, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adpaco-aws adpaco-aws adpaco-aws left review comments

@celinval celinval celinval approved these changes

@zhassan-aws zhassan-aws zhassan-aws approved these changes

Assignees

@feliperodri feliperodri

Labels
None yet
Projects
No open projects
Kani 2023-08-01
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@feliperodri @celinval @adpaco-aws @zhassan-aws