Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds posix_memalign to the list of supported builtins #2601

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

feliperodri
Copy link
Contributor

Description of changes:

Adds posix_memalign to the list of supported libcbuilt-in functions. This function already has a model in CBMC (please, see posix_memalign for details). This will unblock one of our costumers as reported at #2423 (comment).

Resolved issues:

Related to #2543.

Call-outs:

N/A.

Testing:

  • How is this change tested? Regression tests.

  • Is this a refactor change? No.

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@feliperodri feliperodri self-assigned this Jul 11, 2023
@feliperodri feliperodri requested a review from a team as a code owner July 11, 2023 17:55
Copy link
Contributor

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a second test that invokes libc::posix_memalign directly? Thanks!

@feliperodri feliperodri force-pushed the posix_memalign_model branch 3 times, most recently from c66d396 to 3097a49 Compare July 11, 2023 20:07
@feliperodri feliperodri force-pushed the posix_memalign_model branch from 3097a49 to f78ec9f Compare July 11, 2023 20:11
@adpaco-aws adpaco-aws enabled auto-merge (squash) July 11, 2023 20:12
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
@feliperodri feliperodri force-pushed the posix_memalign_model branch from e177db3 to ad9f1fc Compare July 11, 2023 20:17
@adpaco-aws adpaco-aws merged commit ef05529 into model-checking:main Jul 11, 2023
@feliperodri feliperodri deleted the posix_memalign_model branch July 11, 2023 21:13
karkhaz pushed a commit to karkhaz/kani that referenced this pull request Jul 13, 2023
…#2601)

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants