Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable concrete playback for failure of UB checks #2727

Merged
merged 2 commits into from
Sep 2, 2023

Conversation

zhassan-aws
Copy link
Contributor

Description of changes:

Currently, Kani only generates concrete playback tests for checks with the "assertion" property class. This PR enables generating concrete playback tests for other classes of properties as well (e.g. UB checks). Executing those tests normally will likely not result in a failure, but running them with MIRI should show the failure.

Resolved issues:

Towards #2163

Related RFC:

Optional #ISSUE-NUMBER.

Call-outs:

#2163 suggests that concrete playback tests that result in UB should be classified separately. This PR doesn't do that yet, hence I didn't mark it as a resolver for #2163.

Testing:

  • How is this change tested? Added two new tests

  • Is this a refactor change? No

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@zhassan-aws zhassan-aws requested a review from a team as a code owner September 1, 2023 23:34
Copy link
Contributor

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@zhassan-aws zhassan-aws enabled auto-merge (squash) September 2, 2023 00:07
@zhassan-aws zhassan-aws merged commit f23126a into model-checking:main Sep 2, 2023
12 checks passed
@zhassan-aws zhassan-aws deleted the playback-ub branch September 2, 2023 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants