Enable concrete playback for failure of UB checks #2727
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Currently, Kani only generates concrete playback tests for checks with the "assertion" property class. This PR enables generating concrete playback tests for other classes of properties as well (e.g. UB checks). Executing those tests normally will likely not result in a failure, but running them with MIRI should show the failure.
Resolved issues:
Towards #2163
Related RFC:
Optional #ISSUE-NUMBER.
Call-outs:
#2163 suggests that concrete playback tests that result in UB should be classified separately. This PR doesn't do that yet, hence I didn't mark it as a resolver for #2163.
Testing:
How is this change tested? Added two new tests
Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.