Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump CBMC version #2771

Merged
merged 4 commits into from
Sep 15, 2023
Merged

Bump CBMC version #2771

merged 4 commits into from
Sep 15, 2023

Conversation

zhassan-aws
Copy link
Contributor

Description of changes:

Upgrade to latest CBMC version (5.92.0).

Resolved issues:

Related RFC:

Optional #ISSUE-NUMBER.

Call-outs:

Testing:

  • How is this change tested? Current regressions

  • Is this a refactor change? No

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@zhassan-aws zhassan-aws requested a review from a team as a code owner September 15, 2023 16:58
jaisnan
jaisnan approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@jaisnan jaisnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@zhassan-aws zhassan-aws added the Z-BenchCI Tag a PR to run benchmark CI label Sep 15, 2023
@zhassan-aws zhassan-aws added Z-BenchCI Tag a PR to run benchmark CI and removed Z-BenchCI Tag a PR to run benchmark CI labels Sep 15, 2023
@tautschnig tautschnig added Z-BenchCI Tag a PR to run benchmark CI and removed Z-BenchCI Tag a PR to run benchmark CI labels Sep 15, 2023
@zhassan-aws zhassan-aws added Z-BenchCI Tag a PR to run benchmark CI and removed Z-BenchCI Tag a PR to run benchmark CI labels Sep 15, 2023
@zhassan-aws
Copy link
Contributor Author

The failures in the performance benchmarks do not seem significant:

solver_runtime

Benchmark kani_new kani_old % change old → new
s2n-quic/quic/s2n-quic-core/inet::checksum::tests::differential 13.58205 6.40323 +112.112%
s2n-quic/quic/s2n-quic-core/random::tests::gen_range_biased_test 6.5662875 13.6035723 -51.731%

Merging.

@zhassan-aws zhassan-aws merged commit 3f3e1c8 into model-checking:main Sep 15, 2023
12 of 13 checks passed
@zhassan-aws zhassan-aws deleted the cbmc-5.92.0 branch September 15, 2023 23:00
@remi-delmas-3000 remi-delmas-3000 mentioned this pull request Sep 20, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaisnan jaisnan jaisnan approved these changes

Assignees
No one assigned
Labels
Z-BenchCI Tag a PR to run benchmark CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhassan-aws @jaisnan @tautschnig