Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix expected value for pref_align_of under aarch64/macos #2782

Merged
merged 1 commit into from
Sep 20, 2023
Merged

fix expected value for pref_align_of under aarch64/macos #2782

merged 1 commit into from
Sep 20, 2023

Conversation

remi-delmas-3000
Copy link
Contributor

Description of changes:

Sets the expected value for pref_align_of ::<i16> under aarch64/macos to 2 to make tests pass under M1.

Resolved issues:

n/a

Related RFC:

Call-outs:

Testing:

  • How is this change tested? CI

  • Is this a refactor change? No

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@remi-delmas-3000 remi-delmas-3000 requested a review from a team as a code owner September 20, 2023 01:10
jaisnan
jaisnan approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@jaisnan jaisnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but is there any known reason this regression wasn't caught in previous releases?

@remi-delmas-3000 remi-delmas-3000 enabled auto-merge (squash) September 20, 2023 01:57
@remi-delmas-3000 remi-delmas-3000 merged commit a3067ad into model-checking:main Sep 20, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaisnan jaisnan jaisnan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remi-delmas-3000 @jaisnan