Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CBMC version #2796

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Bump CBMC version #2796

merged 3 commits into from
Sep 29, 2023

Conversation

zhassan-aws
Copy link
Contributor

Description of changes:

Upgrade CBMC version to latest (5.93.0).

Resolved issues:

Resolves #2650

Related RFC:

Optional #ISSUE-NUMBER.

Call-outs:

Testing:

  • How is this change tested? Added a test

  • Is this a refactor change? No

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@zhassan-aws zhassan-aws requested a review from a team as a code owner September 29, 2023 17:15
@github-actions github-actions bot added the Z-BenchCI Tag a PR to run benchmark CI label Sep 29, 2023
@celinval celinval added Z-BenchCI Tag a PR to run benchmark CI and removed Z-BenchCI Tag a PR to run benchmark CI labels Sep 29, 2023
@zhassan-aws zhassan-aws added Z-BenchCI Tag a PR to run benchmark CI and removed Z-BenchCI Tag a PR to run benchmark CI labels Sep 29, 2023
@zhassan-aws
Copy link
Contributor Author

I ran the relevant test that failed in the performance benchmarks (check_insert_two_concrete) multiple times locally with the two versions of CBMC, and the time was about the same with both versions, so the results are in the noise.

@zhassan-aws zhassan-aws merged commit 964f986 into model-checking:main Sep 29, 2023
13 of 14 checks passed
@zhassan-aws zhassan-aws deleted the cbmc-5.93.0 branch September 29, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-BenchCI Tag a PR to run benchmark CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spurious failure on harness from s2n-quic
3 participants