Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent kani crash during setup for first time #2799

Merged
merged 5 commits into from
Oct 3, 2023

Conversation

jaisnan
Copy link
Contributor

@jaisnan jaisnan commented Oct 2, 2023

Please ensure your PR description includes the following:

  1. A description of how your changes improve Kani.
  2. Some context on the problem you are solving.
  3. A list of issues that are resolved by this PR.
  4. If you had to perform any manual test, please describe them.

Make sure you remove this list from the final PR description.

By using the tar file as a lock mechanism, we can detect incomplete setups i.e when both kani's working directory and the tar file present before setup, we can simply use the local bundle to start setup again.

This still carries the minor risk that the setup getting interrupted (for the first time) while the tar file is being downloaded. In that case, we can inform the user about the broken tar extraction and ask them to restart the setup process.

Unfortunately, can't be tested automatically.

Resolves #1545

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@jaisnan jaisnan requested a review from a team as a code owner October 2, 2023 18:25
@jaisnan jaisnan changed the title Prevent kani setup crash Prevent kani crash during setup for first time Oct 2, 2023
src/setup.rs Outdated Show resolved Hide resolved
src/setup.rs Outdated Show resolved Hide resolved
@jaisnan jaisnan merged commit 62f136c into model-checking:main Oct 3, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interrupted first-time setup procedure cannot resume
3 participants