Prevent kani crash during setup for first time #2799
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using the
tar
file as a lock mechanism, we can detect incomplete setups i.e when bothkani's
working directory and the tar file present before setup, we can simply use the local bundle to start setup again.This still carries the minor risk that the setup getting interrupted (for the first time) while the tar file is being downloaded. In that case, we can inform the user about the broken tar extraction and ask them to restart the setup process.
Unfortunately, can't be tested automatically.
Resolves #1545
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.