-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Rust toolchain to 2023-10-05 #2802
Conversation
Source changes required by the following upstream commits: * rust-lang/rust@5a0a1ff0cd move ConstValue into mir * rust-lang/rust@ea22adbabd adjust constValue::Slice to work for arbitrary slice types * rust-lang/rust@c94410c145 rename mir::Constant -> mir::ConstOperand, mir::ConstKind -> mir::Const * rust-lang/rust@44ac8dcc71 Remove GeneratorWitness and rename GeneratorWitnessMIR. * rust-lang/rust@4ed4913e67 Merge ExternProviders into the general Providers struct * rust-lang/rust@3c52a3e280 subst -> instantiate * rust-lang/rust@6a02baaa3d Partially outline code inside the panic! macro Fixes: model-checking#2784
Clippy reported a large number of needless_borrows_for_generic_args.
The changes (seemingly) required by rust-lang/rust@4ed4913 break stubbing. I have now issued #2806, which is as far as we can go until we have to face this change. |
Requires changes to support rust-lang/rust@3148e6a9933b (subtyping_projections)
It seems that three of the already-slow tests got even slower. Not sure what to do about this. |
Sometimes, this is due to noise, so I suggest running them locally multiple times to check whether the slow-downs are real. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should merge this despite the performance benchmark single test failure. The failing test is fairly flaky, and the only difference is in solving time. Number of VCCs and program steps didn't change at all.
Source changes required by the following upstream commits:
Resolves: #2811
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.