Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust toolchain to 2023-10-05 #2802

Merged
merged 11 commits into from
Oct 6, 2023

Conversation

tautschnig
Copy link
Member

@tautschnig tautschnig commented Oct 3, 2023

Source changes required by the following upstream commits:

Resolves: #2811

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

Source changes required by the following upstream commits:

* rust-lang/rust@5a0a1ff0cd move ConstValue into mir
* rust-lang/rust@ea22adbabd adjust constValue::Slice to work for arbitrary slice types
* rust-lang/rust@c94410c145 rename mir::Constant -> mir::ConstOperand, mir::ConstKind -> mir::Const
* rust-lang/rust@44ac8dcc71 Remove GeneratorWitness and rename GeneratorWitnessMIR.
* rust-lang/rust@4ed4913e67 Merge ExternProviders into the general Providers struct
* rust-lang/rust@3c52a3e280 subst -> instantiate
* rust-lang/rust@6a02baaa3d Partially outline code inside the panic! macro

Fixes: model-checking#2784
@github-actions github-actions bot added the Z-BenchCI Tag a PR to run benchmark CI label Oct 3, 2023
Clippy reported a large number of needless_borrows_for_generic_args.
@tautschnig tautschnig added Z-BenchCI Tag a PR to run benchmark CI and removed Z-BenchCI Tag a PR to run benchmark CI labels Oct 3, 2023
@tautschnig tautschnig self-assigned this Oct 3, 2023
@tautschnig
Copy link
Member Author

The changes (seemingly) required by rust-lang/rust@4ed4913 break stubbing. I have now issued #2806, which is as far as we can go until we have to face this change.

@tautschnig tautschnig changed the title Update Rust toolchain to 2023-10-03 Update Rust toolchain to 2023-10-04 Oct 4, 2023
@tautschnig tautschnig changed the title Update Rust toolchain to 2023-10-04 Update Rust toolchain to 2023-10-05 Oct 5, 2023
@tautschnig tautschnig added Z-BenchCI Tag a PR to run benchmark CI and removed Z-BenchCI Tag a PR to run benchmark CI labels Oct 5, 2023
@tautschnig tautschnig marked this pull request as ready for review October 5, 2023 14:06
@tautschnig tautschnig requested a review from a team as a code owner October 5, 2023 14:06
@tautschnig
Copy link
Member Author

It seems that three of the already-slow tests got even slower. Not sure what to do about this.

@tautschnig tautschnig removed their assignment Oct 5, 2023
@zhassan-aws
Copy link
Contributor

Sometimes, this is due to noise, so I suggest running them locally multiple times to check whether the slow-downs are real.

Copy link
Contributor

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should merge this despite the performance benchmark single test failure. The failing test is fairly flaky, and the only difference is in solving time. Number of VCCs and program steps didn't change at all.

@tautschnig tautschnig merged commit 88204c2 into model-checking:main Oct 6, 2023
13 checks passed
@tautschnig tautschnig deleted the update-toolchain branch October 6, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-BenchCI Tag a PR to run benchmark CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toolchain upgrade to nightly-2023-09-24 failed
3 participants