Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create concrete playback temp files in source directory #2804

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Create concrete playback temp files in source directory #2804

merged 2 commits into from
Oct 4, 2023

Commits on Oct 4, 2023

  1. Create concrete playback temp files in source directory 

    Concrete playback seeks to generate unit tests in the original source
file. An intermediate temporary file is used to reduce the risk of
corrupting original source files. Once the temporary file has been
completely written to, it is to be atomically moved to replace the
source file. This can only be done on the same file system.

We now create the temporary file in the same source directory as the
original source file to ensure we are on the same file system. The
implementation uses NamedTempFile from the tempfile crate, which renders
our own tempfile implementation redundant.

Tested on Ubuntu 20.04 with /tmp on a different partition (where our
regression tests would previously fail).

Resolves: model-checking#2705
    @tautschnig
    tautschnig committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    4cccf8a View commit details
    Browse the repository at this point in the history

  2. Sync changes

    @tautschnig
    tautschnig committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    2c10486 View commit details
    Browse the repository at this point in the history