install_cbmc.sh: build from source on non-x86_64 #2877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CBMC only provides binaries for x86_64, but it runs fine on other arches (like aarch64) Build from source in that case
|
Thanks @bennofs for the contribution! @adpaco-aws can you review this PR since you're the most familiar with this code? The failure is unrelated to the PR, and is due to a CBMC viewer/python version issue. |
celinval
reviewed
Nov 14, 2023
adpaco-aws
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Thanks @bennofs ! Makes sense, we should build from source in that case.
uname -m seems to report an empty architecture on some systems dpkg --print-architecture is what we care about anyway, since we want to install an amd64 deb
adpaco-aws
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CBMC only provides binaries for x86_64, but it runs fine on other arches (like aarch64) Build from source in that case
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.