[Boogie Backend] Codegen the arguments to Kani intrinsics inside the functions that handle the intrinsics #2924
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor change: currently, the functions that codegen Kani intrinsics (asserts, assumes, etc.) take the arguments to the intrinsics as Boogie expressions (
boogie_ast::boogie_program::Expr
). In other words, the MIR arguments (rustc_middle::mir::syntax::Operand
) are converted to Boogie expressions before passing them to the functions.This PR changes the functions to take the MIR arguments directly, and perform the codegen into Boogie expressions inside the functions. This allows those functions to query any information in the MIR
Operand
, that is not available after codegen to Boogie expressions.Note: it may make sense to do the same change for the Goto backend to avoid having to pattern match on the expressions (e.g.
kani/kani-compiler/src/codegen_cprover_gotoc/overrides/hooks.rs
Line 74 in 2aca488
Resolves #ISSUE-NUMBER
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.