-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cfg=kani_host for host crates #3244
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to run the proofs in the target crate and don't need to build (or run) the proofs in any of the host crates. This avoids a need to make available the `kani` crate to any such host crates. Resolves model-checking#3101, model-checking#3238
feliperodri
approved these changes
Jun 10, 2024
tests/cargo-kani/build-rs-plus-host-with-kani-proofs/constants/Cargo.toml
Outdated
Show resolved
Hide resolved
feliperodri
added
T-High Priority
Tag issues that have high priority
T-User
Tag user issues / requests
labels
Jun 10, 2024
Co-authored-by: Felipe R. Monteiro <rms.felipe@gmail.com>
…/Cargo.toml Co-authored-by: Felipe R. Monteiro <rms.felipe@gmail.com>
celinval
reviewed
Jun 10, 2024
celinval
reviewed
Jun 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this
tests/cargo-kani/build-rs-plus-host-with-kani-proofs/binary/build.rs
Outdated
Show resolved
Hide resolved
tests/cargo-kani/build-rs-plus-host-with-kani-proofs/binary/build.rs
Outdated
Show resolved
Hide resolved
tests/cargo-kani/build-rs-plus-host-with-kani-proofs/constants/src/lib.rs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to run the proofs in the target crate and don't need to build (or run) the proofs in any of the host crates. This avoids a need to make available the
kani
crate to any such host crates.Resolves #3101, #3238
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.