Fix the computation of the number of bytes of a pointer offset #3584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celinval
reviewed
Oct 9, 2024
|
Are we perhaps making the same mistake in |
|
The usage of the pointer instead of the pointee was causing the soundness issue and spurious failures in the multiplication operation used for computing the number of bytes. Both soundness/spurious issues are fixed by this PR. But the remaining spurious failures are in the addition operation (adding the pointer value to the number of bytes). I'm not clear on their cause yet. |
celinval
approved these changes
Oct 9, 2024
Merged
via the queue into
model-checking:main
with commit Oct 9, 2024
c645752
26 of 27 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the logic that computes the number of bytes of a pointer offset. The logic was incorrectly using the size of the pointer as opposed to the size of the pointee.
This fixes the soundness issue in #3582 (but not the spurious failures).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.