-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contract and Harnesses for byte_add
, byte_sub
and byte_offset
#169
Conversation
- Also adds proofs verifying unit, int and composite types.
- Adds harnesses for int, unit, composite and slice types
@feliperodri FYI |
<*mut T>::byte_add
, byte_sub
and byte_offset
byte_add
, byte_sub
and byte_offset
@jswrenn could you give another round of review for this one? I believe they have addressed all your comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two final nits, which you're welcome to take or leave.
Thanks for the contribution!
…ting to unit type
eea35b0
to
eab2c65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for all the hard work on this.
…nd `byte_offset` (#188) Towards #76 This pull request impelments proof for contracts for `byte_add`, `byte_sub` and `byte_offset` for `<dyn Trait>`. Both `const` and `mut` versions are included. It serves as an addition to an existing [PR](#169) but is submitted separately to avoid disrupting the ongoing review process for that PR. --------- Co-authored-by: Surya Togaru <stogaru@andrew.cmu.edu> Co-authored-by: stogaru <143449212+stogaru@users.noreply.github.com> Co-authored-by: Felipe R. Monteiro <rms.felipe@gmail.com>
Towards #76
Changes
<*mut T>::byte_add
,<*mut T>::byte_sub
and<*mut T>::byte_offset
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.