Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid syntax errors. #3496

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Avoid syntax errors. #3496

wants to merge 2 commits into from

Conversation

HansOlsson
Copy link
Collaborator

Avoid the use of {} that isn't described in the grammar.

@HansOlsson HansOlsson added the bug Something isn't working label Apr 2, 2024
Copy link
Collaborator

@henrikt-ma henrikt-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the old way with {} much more clear, and it has never been a concern to me that annotations are defined using a style which only reminds of – but isn't exactly – Modelica.

We already have the big discrepancy that there is no built-in record called Documentation, and that's not a problem.

I see two better-looking alternatives to fill("foo", 0):

@HansOlsson HansOlsson requested a review from henrikt-ma April 30, 2024 11:23
Copy link
Collaborator

@henrikt-ma henrikt-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing really changed since my previous review. More discussion is needed to sort this out.

@HansOlsson HansOlsson added this to the 2024-September milestone Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants