Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve #4336 #4418

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Resolve #4336 #4418

merged 1 commit into from
Jun 24, 2024

Conversation

AHaumer
Copy link
Contributor

@AHaumer AHaumer commented Jun 11, 2024

  • remove ill-defined pmActuator.coil.L_stat from comparisonSignals.txt for Modelica.Magnetic.FluxTubes.Examples.MovingCoilActuator.ForceCurrentBehaviour
  • define output interval for all 3 examples Modelica.Magnetic.FluxTubes.Examples.MovingCoilActuator

@AHaumer AHaumer added bug Critical/severe issue L: Magnetic.FluxTubes Issue addresses Modelica.Magnetic.FluxTubes labels Jun 11, 2024
@AHaumer AHaumer added this to the MSL4.1.0 milestone Jun 11, 2024
@AHaumer AHaumer mentioned this pull request Jun 11, 2024
Open
4 tasks
@AHaumer AHaumer enabled auto-merge June 11, 2024 17:12
@beutlich beutlich added the example Issue only addresses example(s) label Jun 11, 2024
casella
casella approved these changes Jun 22, 2024
View reviewed changes
Copy link
Contributor

@casella casella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

HansOlsson
HansOlsson reviewed Jun 23, 2024
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with removing the signals and the new Interval for ArmatureStroke (in order to see the accelerations in the armature that happens in very short bursts).

But I don't see why we have so short Interval for the other two models - to me it seems 0.01 s would work as well. To me if someone sets a very small Interval I expect that there is something relevant on that time-scale, and I don't know which signal.

BTW: The documentation is broken for those two models (and likely have been for quite some time) - it refers to flange_b for components that only have flange.

@AHaumer AHaumer merged commit 9fb423e into modelica:master Jun 24, 2024
2 checks passed
@HansOlsson HansOlsson mentioned this pull request Jun 28, 2024
Open
@casella casella removed this from the MSL4.1.0 milestone Jun 28, 2024
@Esther-Devakirubai
Copy link
Contributor

@casella Can this be backported to maint/4.1.0? No milestone mentioned.

@casella
Copy link
Contributor

casella commented Jul 31, 2024

Please do, this resolves #4336, please also close that once the backport is merged in.

@beutlich beutlich mentioned this pull request Aug 14, 2024
Merged
@beutlich beutlich added this to the maintenance milestone Aug 19, 2024
@Esther-Devakirubai
Copy link
Contributor

Backported to maintenance branch by #4447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansOlsson HansOlsson HansOlsson left review comments

@casella casella casella approved these changes

@maltelenz maltelenz maltelenz approved these changes

Assignees
No one assigned
Labels
bug Critical/severe issue example Issue only addresses example(s) L: Magnetic.FluxTubes Issue addresses Modelica.Magnetic.FluxTubes
Projects
None yet
Milestone
maintenance
Development

Successfully merging this pull request may close these issues.
6 participants
@AHaumer @Esther-Devakirubai @casella @maltelenz @HansOlsson @beutlich