Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New UI for permission management #1269

Merged
merged 5 commits into from
Dec 19, 2024
Merged

New UI for permission management #1269

merged 5 commits into from
Dec 19, 2024

Conversation

slisson
Copy link
Member

@slisson slisson commented Dec 19, 2024

No description provided.

@slisson
fix(model-server): ignite failed to start because of missing permissions
01bdd2b 
It couldn't create the directory `/usr/modelix-model/ignite/work`.
@slisson slisson force-pushed the MODELIX-1051-Nicer-UI-for-permission-management branch from 4bf9756 to f499a71 Compare December 19, 2024 13:14
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2024 •
edited
Loading

JVM coverage report

Overall Project 54.5% -1.01% ❌
Files changed 20.83% ❌

File Coverage
PageWithMenuBar.kt 100% 🍏
SchemaInstance.kt 79.3% -3.38% ❌
AuthorizationPlugin.kt 72.61% 🍏
PermissionParser.kt 62.32% -37.68% ❌
AccessControlData.kt 42.23% -5.02% ❌
PermissionManagementPage.kt 22.73% -72.42% ❌
Main.kt 18.74% -1.04% ❌
RepositoryOverview.kt 13.33% -15.42% ❌
DBAccessControlPersistence.kt 0% ❌
PermissionSchemaPage.kt 0% -4.55% ❌

@slisson slisson force-pushed the MODELIX-1051-Nicer-UI-for-permission-management branch from 79d170b to 6d60ce5 Compare December 19, 2024 13:22
@slisson
feat(authorization): easier to understand UI for permission management
93cd0be 
Each resource has now a separate page which can be used in links for integration into other UIs.
@slisson
feat(model-server): persist access control data into database
da25835
@slisson
feat(model-server): added links for permission management to the repo…
2a3aab7 
…sitory overview page
@slisson
chore(authorization): remove unused deniedPermissionRequests
5add048 
After redesigning the UI, permission management become easier to understand, and we don't need this
feature anymore.
@slisson slisson force-pushed the MODELIX-1051-Nicer-UI-for-permission-management branch from 6d60ce5 to 5add048 Compare December 19, 2024 13:25
@github-actions GitHub Actions
Copy link
Contributor

Test Results

  193 files  ±0    193 suites  ±0   33m 58s ⏱️ + 1m 55s
1 078 tests ±0  1 069 ✅ +1  9 💤 ±0  0 ❌  - 1 
1 088 runs  ±0  1 079 ✅ +1  9 💤 ±0  0 ❌  - 1 

Results for commit 5add048. ± Comparison against base commit d05eaf6.

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 19, 2024
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@slisson slisson merged commit e3fb1da into main Dec 19, 2024
21 checks passed
@slisson slisson deleted the MODELIX-1051-Nicer-UI-for-permission-management branch December 19, 2024 13:51
@slisson
Copy link
Member Author

slisson commented Dec 19, 2024

🎉 This PR is included in version 11.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@slisson