Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nose to pytest conversion #221

Merged
merged 6 commits into from
Nov 20, 2024
Merged

nose to pytest conversion #221

merged 6 commits into from
Nov 20, 2024

Conversation

PeterMeisrimelModelon
Copy link
Collaborator

No description provided.

@PeterMeisrimelModelon PeterMeisrimelModelon self-assigned this Feb 13, 2024
modelonrobinandersson
modelonrobinandersson approved these changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@modelonrobinandersson modelonrobinandersson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just minor comments.
Do all the tests pass on both Windows and Linux?

tests/test_fmi.py Outdated Show resolved Hide resolved
tests/test_fmi.py Outdated Show resolved Hide resolved
tests/test_io.py Show resolved Hide resolved
tests/test_io.py Outdated Show resolved Hide resolved
@PeterMeisrimelModelon PeterMeisrimelModelon force-pushed the dev-pm-python311 branch 2 times, most recently from 494b9c4 to 5b84da8 Compare February 29, 2024 16:20
Base automatically changed from dev-pm-python311 to master May 30, 2024 14:44
@PeterMeisrimelModelon PeterMeisrimelModelon force-pushed the dev-pm-pytest branch 2 times, most recently from eda3a4b to 65404d0 Compare October 30, 2024 10:10
PeterMeisrimelModelon and others added 4 commits November 14, 2024 15:39
@PeterMeisrimelModelon
Replacing nose by pytest
5769521 
Resolving some Warnings; Adding pytest.ini

Fixing deprecationWarnings

cleanup

Apply suggestions from code review

Co-authored-by: Robin Andersson <robin.andersson@modelon.com>

More review comment fixes

Adding pytest.ini to test folder for automatic detection

rebase fix

replacing nose
cleanup
b4b12c9
Cleanup
5706885 
more rebase fixes

more rebase cleanup

more rebase cleanup

Removing tests as module; moved test files to tests/files

moved test_util to pyfmi/src

Adding pytest config

fixed example path

replaced tests conditional to Assimulo installation by markers

simplified workflow file; added changelog
converting tests from latest changes on master
420081b
modelonrobinandersson
modelonrobinandersson reviewed Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@modelonrobinandersson modelonrobinandersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice nicely done with the clean-up also!
I am approving since I had just minor optional comments.

src/pyfmi/master.pyx Show resolved Hide resolved
tests/test_fmi_coupled.py Show resolved Hide resolved
@PeterMeisrimelModelon
Copy link
Collaborator Author

Looks good, just minor comments. Do all the tests pass on both Windows and Linux?

All the tests pass on both Windows and Linux.

@PeterMeisrimelModelon PeterMeisrimelModelon merged commit 70bdb25 into master Nov 20, 2024
2 checks passed
@PeterMeisrimelModelon PeterMeisrimelModelon deleted the dev-pm-pytest branch November 20, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@modelonrobinandersson modelonrobinandersson modelonrobinandersson approved these changes

Assignees

@PeterMeisrimelModelon PeterMeisrimelModelon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PeterMeisrimelModelon @modelonrobinandersson