Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix single gpu case #217

Merged
merged 1 commit into from
Feb 22, 2024
Merged

fix single gpu case #217

merged 1 commit into from
Feb 22, 2024

Conversation

drcege
Copy link
Collaborator

@drcege drcege commented Feb 22, 2024

There is a special case where datasets.map does not start multiprocessing when set to run on a single GPU.

Previously, get_model would only use the GPU during multiprocessing, leading to the model not being transferred to CUDA in the single-process setting.

@drcege drcege added bug Something isn't working enhancement New feature or request labels Feb 22, 2024
@drcege drcege self-assigned this Feb 22, 2024
Copy link
Collaborator

@HYLcool HYLcool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Conflicts in this file between #200 and this PR should be resolved with @BeachWang

@BeachWang BeachWang merged commit 5a4001f into main Feb 22, 2024
5 checks passed
@drcege drcege deleted the fix/gpu branch March 11, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants