Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix readme link #228

Merged
merged 18 commits into from
Mar 7, 2024
Merged

fix readme link #228

merged 18 commits into from
Mar 7, 2024

Conversation

zhijianma
Copy link
Collaborator

No description provided.

@drcege
Copy link
Collaborator

drcege commented Mar 7, 2024

@yxdyc

Besides, the subsection titled Documentation Index | 文档索引 is always presented side by side in both README.md and README_ZH.md. Could this be considered slightly redundant? Especially for developers who are not familiar with Chinese, it might come across as a mess.

Copy link
Collaborator

@yxdyc yxdyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HYLcool
Copy link
Collaborator

HYLcool commented Mar 7, 2024

Please change the version to 0.2.0 in the data_juicer/init.py also~

@yxdyc
Copy link
Collaborator

yxdyc commented Mar 7, 2024

@yxdyc

Besides, the subsection titled Documentation Index | 文档索引 is always presented side by side in both README.md and README_ZH.md. Could this be considered slightly redundant? Especially for developers who are not familiar with Chinese, it might come across as a mess.

Agree, please @zhijianma also modify accordingly.

@zhijianma zhijianma merged commit 156ed20 into modelscope:main Mar 7, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants