Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new OP: token_num_filter #24

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Add new OP: token_num_filter #24

merged 3 commits into from
Sep 19, 2023

Conversation

HYLcool
Copy link
Collaborator

@HYLcool HYLcool commented Sep 18, 2023

  • Add a new OP: token_num_filter
    • Allow specify any valid tokenizer from hugging face to compute the token number of samples

zhijianma
zhijianma approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@zhijianma zhijianma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HYLcool HYLcool merged commit 99ef53b into main Sep 19, 2023
@HYLcool HYLcool mentioned this pull request Sep 19, 2023
Closed
@HYLcool HYLcool added the enhancement New feature or request label Sep 19, 2023
@HYLcool HYLcool deleted the feature/token_num_filter branch October 16, 2023 03:46
@HYLcool HYLcool added the dj:op issues/PRs about some specific OPs label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhijianma zhijianma zhijianma approved these changes

@yxdyc yxdyc Awaiting requested review from yxdyc

Assignees
No one assigned
Labels
dj:op issues/PRs about some specific OPs enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HYLcool @zhijianma