Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/optimize cache dir selection #43

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Fix/optimize cache dir selection #43

merged 3 commits into from
Oct 25, 2023

Conversation

HYLcool
Copy link
Collaborator

@HYLcool HYLcool commented Oct 25, 2023

Optimize the cache dir selection strategy:

  • If users do not specify a ds_cache_dir, Data-Juicer uses the environment variable HF_DATASETS_CACHE instead to store the cache files.
  • Otherwise, Data-Juicer uses ds_cache_dir and outputs a warning

Ref: issue #41

yxdyc
yxdyc approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@yxdyc yxdyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhijianma
zhijianma approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@zhijianma zhijianma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HYLcool HYLcool merged commit ca1834e into main Oct 25, 2023
3 checks passed
@HYLcool HYLcool deleted the fix/optimize_cache_dir_selection branch October 25, 2023 05:57
@HYLcool HYLcool mentioned this pull request Oct 25, 2023
Closed
3 tasks
@HYLcool HYLcool linked an issue Oct 25, 2023 that may be closed by this pull request
[Bug]: formatter 调用 datasets.load_dataset 时缓存位置问题 #41
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yxdyc yxdyc yxdyc approved these changes

@zhijianma zhijianma zhijianma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: formatter 调用 datasets.load_dataset 时缓存位置问题
3 participants
@HYLcool @zhijianma @yxdyc