Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] fix eslint warning #187

Closed
4 tasks done
soonki-98 opened this issue Oct 8, 2022 · 0 comments · Fixed by #189, #190, #191, #192 or #193
Closed
4 tasks done

[Fix] fix eslint warning #187

soonki-98 opened this issue Oct 8, 2022 · 0 comments · Fixed by #189, #190, #191, #192 or #193
Assignees
@soonki-98
Milestone
v2.0.0

Comments

@soonki-98
Copy link
Member

soonki-98 commented Oct 8, 2022 •
edited
Loading

Description

eslint warning 수정

Progress

  • Do not use Array index in keys
  • something is missing in props validation
  • Value must be omitted for boolean attributes
  • Curly braces are unnecessary here
@soonki-98 soonki-98 self-assigned this Oct 8, 2022
@soonki-98 soonki-98 added this to the v2.0.0 milestone Oct 8, 2022
@soonki-98 soonki-98 mentioned this issue Oct 8, 2022
Merged
soonki-98 added a commit that referenced this issue Oct 8, 2022
@soonki-98
fix: do not use Array index in keys warning (#187)
b378bbe
soonki-98 added a commit that referenced this issue Oct 8, 2022
@soonki-98
Merge branch 'develop' into feature/msk/#187
a7fd93a
soonki-98 added a commit that referenced this issue Oct 8, 2022
@soonki-98
fix: value must be omitted for boolean attributes warning (#187)
4414635
soonki-98 added a commit that referenced this issue Oct 8, 2022
@soonki-98
fix: curly braces are unnecessary here (#187)
997d62e
soonki-98 added a commit that referenced this issue Oct 8, 2022
@soonki-98
fix: something is missing in props validation (#187)
64486bb
@soonki-98 soonki-98 linked a pull request Oct 8, 2022 that will close this issue
fix: fix eslint warning (#187) #189
Merged
soonki-98 added a commit that referenced this issue Oct 8, 2022
@soonki-98
Merge pull request #189 from modern-agile-team/feature/msk/#187
ba6ddc8 
fix: fix eslint warning (#187)
@soonki-98 soonki-98 linked a pull request Oct 8, 2022 that will close this issue
fix: ESLint error: Parsing error #190
Merged
soonki-98 added a commit that referenced this issue Oct 8, 2022
@soonki-98
Merge pull request #190 from modern-agile-team/feature/msk/#187
01bcdf9 
fix: ESLint error: Parsing error
soonki-98 added a commit that referenced this issue Oct 8, 2022
@soonki-98
fix: fix 'npm run lint' error (#187)
b0c56e2
soonki-98 added a commit that referenced this issue Oct 8, 2022
@soonki-98
Merge pull request #191 from modern-agile-team/feature/msk/#187
c537891 
fix: fix 'npm run lint' error (#187)
@soonki-98 soonki-98 linked a pull request Oct 8, 2022 that will close this issue
fix: fix 'npm run lint' error (#187) #191
Merged
soonki-98 added a commit that referenced this issue Oct 8, 2022
@soonki-98
Merge pull request #192 from modern-agile-team/feature/msk/#187
17d67bc 
fix: statement not part of import statement
@soonki-98 soonki-98 linked a pull request Oct 8, 2022 that will close this issue
fix: statement not part of import statement #192
Merged
soonki-98 added a commit that referenced this issue Oct 8, 2022
@soonki-98
fix: specify type to sideBarItems state (#187)
d600c00
@soonki-98 soonki-98 linked a pull request Oct 8, 2022 that will close this issue
fix: specify type to sideBarItems state (#187) #193
Merged
soonki-98 added a commit that referenced this issue Oct 8, 2022
@soonki-98
Merge pull request #193 from modern-agile-team/feature/msk/#187
cf747a5 
fix: specify type to sideBarItems state (#187)
soonki-98 added a commit that referenced this issue Oct 8, 2022
@soonki-98
fix: fix conflict (#187)
f3ae5cb
soonki-98 added a commit that referenced this issue Oct 8, 2022
@soonki-98
Merge pull request #195 from modern-agile-team/feature/msk/#187
cc9e0ac 
fix: fix conflict (#187)
github-actions bot pushed a commit that referenced this issue Oct 8, 2022
@semantic-release-bot
chore(release): 2.1.0 [skip ci]
107ed33 
# [2.1.0](v2.0.0...v2.1.0) (2022-10-08)

### Bug Fixes

* curly braces are unnecessary here ([#187](#187)) ([997d62e](997d62e))
* do not use Array index in keys warning ([#187](#187)) ([b378bbe](b378bbe))
* eSLint error: Parsing error ([94ff2cf](94ff2cf))
* fix 'npm run lint' error ([#187](#187)) ([b0c56e2](b0c56e2))
* fix conflict ([#187](#187)) ([f3ae5cb](f3ae5cb))
* something is missing in props validation ([#187](#187)) ([64486bb](64486bb))
* specify type to sideBarItems state ([#187](#187)) ([d600c00](d600c00))
* statement not part of import statement (@typescript-eslint/no-var-requires) ([230c28d](230c28d))
* value must be omitted for boolean attributes warning ([#187](#187)) ([4414635](4414635))

### Features

* creat uuidv4 util function ([#187](#187)) ([92f9f9f](92f9f9f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soonki-98 soonki-98

Labels
None yet
Projects
None yet
Milestone
v2.0.0
1 participant
@soonki-98