Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Lighthouse CI GitHub Action #110

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Adds Lighthouse CI GitHub Action #110

merged 3 commits into from
Oct 16, 2023

Conversation

ChrisMKindred
Copy link
Contributor

Due to a limitation in GitHub actions, this will need to be merged to the main branch before running the workflow as a full test.

What does this do/fix?

This PR creates a Lighthouse CI Action that can be run via a workflow_dispatch. When the workflow runs, it will query one to many (line separated) of the URLs listed in the urls param. The results will trigger an error or warning in the action UI based on the config settings in the lighthouserc.json file. These settings should be customized for each production site based on the current performance. The full report is also added to the action artifacts, which can be disabled by changing the uploadArtifacts param to false.

This action aims to eventually run after deployments to test the site and trigger notifications if there are any performance, accessibility, SEO, or best practice degradations.

Copy link
Collaborator

@dpellenwood dpellenwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I wonder if we should add some instructions to the project readme for this? Also: should this have a changelog entry?

@ChrisMKindred
Copy link
Contributor Author

@dpellenwood Yes, I will add both a readme/instructions and changelog but I need to get it merged into main first to make sure that everything runs.

@ChrisMKindred ChrisMKindred merged commit 6b20059 into main Oct 16, 2023
10 checks passed
@ChrisMKindred ChrisMKindred deleted the feature/lighthouse-ci branch October 16, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants