Feature/moose 66 update post content selector #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e admin & editor.
dpellenwood
requested review from
jamiepaul,
ChrisMKindred,
Vinsanity,
GeoffDusome and
LayaTaal
dpellenwood
commented
Oct 27, 2023
GeoffDusome
approved these changes
Oct 27, 2023
GeoffDusome
reviewed
Oct 31, 2023
Comment on lines
+5
to
+41
| .wp-block-list { | ||
|
|
||
| &::marker { | ||
| font-weight: var(--font-weight-bold); | ||
| } | ||
| li ~ li { | ||
| margin-top: var(--spacer-30); | ||
| } | ||
|
|
||
| /* ---------------------------------------------------------------------- | ||
| * CASE: Ordered List | ||
| * ---------------------------------------------------------------------- */ | ||
|
|
||
| ol& { | ||
| padding-inline-start: 1.2rem; | ||
|
|
||
| li { | ||
| padding-inline-start: 10px; | ||
|
|
||
| & ~ li { | ||
| margin-top: var(--spacer-30); | ||
| &::marker { | ||
| font-weight: var(--font-weight-bold); | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| /* ---------------------------------------------------------------------- | ||
| * Unordered List | ||
| * | ||
| * The first selector applies to the FE, the second in the editor. | ||
| * The list block is the only block on the FE that doesn't get a class, | ||
| * so we're able to apply a :not() selector for the class attribute. | ||
| * While both will apply in the editor, only the second will affect | ||
| * the actual list block. | ||
| * ---------------------------------------------------------------------- */ | ||
|
|
||
| .wp-site-blocks ul:not([class]), | ||
| ul.wp-block-list { | ||
| padding-inline-start: 10px; | ||
|
|
||
| & li { | ||
| padding-inline-start: 1.3rem; | ||
| position: relative; | ||
|
|
||
| &::marker { | ||
| content: var(--icon-list-bullet); | ||
| transform: translateX(10px); | ||
| } | ||
| /* ---------------------------------------------------------------------- | ||
| * CASE: Unordered List | ||
| * ---------------------------------------------------------------------- */ | ||
|
|
||
| ul& { | ||
| padding-inline-start: 10px; | ||
|
|
||
| li { | ||
| padding-inline-start: 1.3rem; | ||
| position: relative; | ||
|
|
||
| & ~ li { | ||
| margin-top: var(--spacer-30); | ||
| &::marker { | ||
| content: var(--icon-list-bullet); | ||
| transform: translateX(10px); | ||
| } |
There was a problem hiding this comment.
@dpellenwood I'm getting some warnings in postcss when trying to use these styles due to the ul& and ol& not having a symbol to start:
postcss-nesting: Nested selectors must start with a symbol and "ul&" begins with a letter.
There was a problem hiding this comment.
Interesting. I know that this was a later change to the spec, but it is valid now. (The second code example under this heading.) I think your project may not be using the latest version of postcss-preset-env or similar. That selector doesn't cause any errors here on Moose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do/fix?
wp-site-blocksin css selectors to use thewp-block-post-contentselector instead. The post-content should always appear in the editor and on the FE, so this single selector is a nice simplifier.Ticket: MOOSE-66