[MOOSE-51]: Color Names #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vinsanity
requested review from
jamiepaul,
dpellenwood,
GeoffDusome and
LayaTaal
jamiepaul
approved these changes
Jan 26, 2024
| * Brand Colors: | ||
| * When assigning brand colors, please use color names rather than primary | ||
| * or secondary, etc. | ||
| * Color Naming Site: https://chir.ag/projects/name-that-color/ |
There was a problem hiding this comment.
❤️ love that name generator tool!
GeoffDusome
approved these changes
Jan 29, 2024
|
@Vinsanity , think you have a couple minutes to merge this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change primary and secondary color names to the name of the colors.
What does this do/fix?
The use of
primaryandsecondaryas Brand color names did not fit with all projects.I did not change the use of Primary and Secondary as a name for button style variations.
QA
Links to relevant issues