BE: Remove SquareOne libs dependencies #161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpellenwood
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Looks great, @MlKilderkin ! I'd like @JMRhodes to give this one a look as well before you merge.
JMRhodes
reviewed
Nov 5, 2024
| * | ||
| * Maps requests for meta keys to the Meta_Group responsible for handling it | ||
| */ | ||
| class Meta_Map { |
There was a problem hiding this comment.
Did these come over from Libs? Wondering if that's still necessary. Similar question with Meta_Group and Meta_Respository?
There was a problem hiding this comment.
Yes @JMRhodes this is from Libs. If we don't need something like this
public function get_meta( string $key ): mixed {
return $this->meta->get_value( $this->post_id, $key );
}
for meta pulling we can remove this
There was a problem hiding this comment.
@MlKilderkin what are your thoughts on it? Do you find it useful in your projects? Certainly fine keeping it in there if we're utilizing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do/fix?
Remove SquareOne libs dependencies
Add required abstract classes
Update tests
QA
Links to relevant issues