Fix/moose 169/remove unnecessary theme support calls #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… map classes using our DI system.
… These are already applied for block themes.
dpellenwood
requested review from
Vinsanity,
JMRhodes,
GeoffDusome,
LayaTaal and
lindseyolson
dpellenwood
deleted the
fix/MOOSE-169/remove-unnecessary-theme-support-calls
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do/fix?
Block themes already apply most traditional theme_support features in WordPress. From FSE.com:
And, adding
title-tagtheme support actually causes a bug in Yoast SEO to surface where the title is erroneously injected twice into each document.This PR removes unnecessary
add_theme_support()calls from Moose.Additionally, this PR adds the
.phpstorm.meta.phpfile to tell storm how to handle our DI container class mapping.QA
Links to relevant issues
Screenshots/video: