Chore/moose 159/package updates #166
Conversation
…'t excluding recent versions of Safari.
dpellenwood
requested review from
Vinsanity,
JMRhodes,
GeoffDusome,
LayaTaal and
lindseyolson
| @@ -1 +1 @@ | |||
| 20.16.0 | |||
| 22.11.0 | |||
There was a problem hiding this comment.
This is the current LTS (Jod). I haven't bumped the minimum required engine in our package.json file as v20 is still under LTS maintenance support.
| @@ -11,9 +11,9 @@ | |||
| "email": "admin@tri.be" | |||
| }, | |||
| "browserslist": [ | |||
| "last 2 versions", | |||
There was a problem hiding this comment.
This was excluding all versions of Safari under v18.0, which is bad as not many people have migrated to the latest version of MacOS/iOS yet.
| "last 2 versions", | ||
| "not op_mini all", | ||
| "not dead" | ||
| "defaults", |
There was a problem hiding this comment.
Simpler set of browsers to remember while still supporting the older versions of Safari we need.
| "not op_mini all", | ||
| "not dead" | ||
| "defaults", | ||
| "not ios < 17.5", |
There was a problem hiding this comment.
Just curious why you decided to include this? It looks like without it we are included some 16.x versions of Safari? I just wonder if it is ok to keep those so we don't have to remember to keep updating this line as things move forward.
There was a problem hiding this comment.
Good question. Correct. The "defaults" key still supports 16.6, 16.7, and 15.6-8. We don't want or need to support those really old versions of Safari as they often lack features we want to use.
The usage on those versions is minimal; and, since those versions are no longer supported by Apple, I don't see a reason to keep them.
What does this do/fix?
QA
Links to relevant issues