Skip to content

Commit

Permalink
ci(commit.yml): fix silently failing test step (#2335)
Browse files Browse the repository at this point in the history
The CI test step was suppressing errors, I think because we ran coverage immediately after. Move coverage to a subsequent step. This reveals a few failing tests which are not addressed in this changeset.
  • Loading branch information
wpbonelli authored Oct 15, 2024
1 parent f378f84 commit e75d065
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion .github/workflows/commit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -181,10 +181,13 @@ jobs:
working-directory: autotest
run: |
pytest -v -m="not example" -n=auto --cov=flopy --cov-append --cov-report=xml --durations=0 --keep-failed=.failed --dist loadfile
coverage report
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Report coverage
working-directory: autotest
run: coverage report

- name: Upload failed test outputs
uses: actions/upload-artifact@v4
if: failure()
Expand Down

0 comments on commit e75d065

Please sign in to comment.