Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_destination_pathline_data returns all pathlines traveling through dest_cells #1029

Closed
TroelsNV opened this issue Dec 10, 2020 · 1 comment · Fixed by #1171
Closed

get_destination_pathline_data returns all pathlines traveling through dest_cells #1029

TroelsNV opened this issue Dec 10, 2020 · 1 comment · Fixed by #1171
Assignees
Milestone

Comments

@TroelsNV
Copy link

This is not really a bug, but maybe a clarification is needed in the documentation, or the code should be changed.

In: get_destination_pathline_data function from modpathfile.py, all pathlines are returned that travels through the specific destination cell. The part of the code is copied below.

line 397: dest_cells = np.array(dest_cells, dtype=raslice.dtype) # get destination cells
line 398: inds = np.in1d(raslice, dest_cells) # return boolean array based on destination cells
line 399: epdest = ra[inds].copy().view(np.recarray) # return cells where the pathline travels through

Line 398 returns a boolean array of all particle traces that goes through a specific cell, and not only the particles that end in the specific destination cells.

Maybe it should be more clearly defined that it is not necessarily the particles that end in the cell but also particles traveling through.

An example can be seen in this setup, where a well is located in cell [[(2000739,)]], but some particles travel through without stopping in the cell.

model_ws.zip

@jdhughes-usgs jdhughes-usgs added this to the 3.3.4 milestone Feb 18, 2021
@jdhughes-usgs jdhughes-usgs self-assigned this Feb 18, 2021
@langevin-usgs
Copy link
Contributor

I believe this is in response to #993. Thanks @TroelsNV!

jdhughes-usgs added a commit to jdhughes-usgs/flopy that referenced this issue Aug 6, 2021
Reorganize MODFLOW 6 tutorials and rename a few.

Closes modflowpy#1029
jdhughes-usgs added a commit that referenced this issue Aug 6, 2021
Reorganize MODFLOW 6 tutorials and rename a few.

Closes #1029
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants