Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(numpy): aliases of builtin types is deprecated #1105

Merged
merged 1 commit into from
May 7, 2021

Conversation

mwtoews
Copy link
Contributor

@mwtoews mwtoews commented May 6, 2021

This is a re-do of #1052 for changes from #1078.

@@ -57,7 +57,7 @@ class Raster:
FLOAT64 = (np.float64,)
INT8 = (np.int8,)
INT16 = (np.int16,)
INT32 = (int, np.int, np.int32, np.uint32)
INT32 = (int, np.int32, np.uint32)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, FYI int is 32-bits on Windows and 64-bits on most other computers. This issue is not addressed in this PR.

@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #1105 (df3c87f) into develop (f3124b5) will increase coverage by 0.978%.
The diff coverage is 50.000%.

❗ Current head df3c87f differs from pull request most recent head 14a842a. Consider uploading reports for the commit 14a842a to get more accurate results

@@              Coverage Diff              @@
##           develop     #1105       +/-   ##
=============================================
+ Coverage   71.748%   72.727%   +0.978%     
=============================================
  Files          225       221        -4     
  Lines        51856     51081      -775     
=============================================
- Hits         37206     37150       -56     
+ Misses       14650     13931      -719     
Impacted Files Coverage Δ
flopy/plot/crosssection.py 55.712% <40.000%> (ø)
flopy/plot/map.py 70.748% <50.000%> (ø)
flopy/utils/rasters.py 56.589% <100.000%> (ø)
flopy/modflow/mfswi2.py 62.461% <0.000%> (-9.847%) ⬇️
flopy/modflow/mfoc.py 91.732% <0.000%> (-2.953%) ⬇️
flopy/modflow/mfbcf.py 87.939% <0.000%> (-2.011%) ⬇️
flopy/utils/datafile.py 72.811% <0.000%> (-1.383%) ⬇️
flopy/utils/mfreadnam.py 76.642% <0.000%> (-0.730%) ⬇️
flopy/utils/flopy_io.py 75.641% <0.000%> (-0.428%) ⬇️
flopy/mt3d/mtcts.py
... and 3 more

@langevin-usgs langevin-usgs merged commit 6c328e1 into modflowpy:develop May 7, 2021
@mwtoews mwtoews deleted the numpy-dtype branch June 23, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants