refactor(exe_name): remove unnecessary ".exe" suffix #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1563 +/- ##
=======================================
Coverage 72.4% 72.4%
=======================================
Files 251 251
Lines 54216 54215 -1
=======================================
+ Hits 39300 39303 +3
+ Misses 14916 14912 -4
|
langevin-usgs
approved these changes
Sep 30, 2022
mwtoews
added a commit
to mwtoews/flopy
that referenced
this pull request
Oct 13, 2022
* Allow write_gridlines_shapefile to write .prj file * Add test_write_gridlines_shapefile * Add remaining file missed from modflowpy#1563 for Mt3dms
wpbonelli
pushed a commit
to wpbonelli/flopy
that referenced
this pull request
Dec 14, 2022
wpbonelli
pushed a commit
to wpbonelli/flopy
that referenced
this pull request
Dec 14, 2022
…odflowpy#1583) * Allow write_gridlines_shapefile to write .prj file * Add test_write_gridlines_shapefile * Add remaining file missed from modflowpy#1563 for Mt3dms
wpbonelli
pushed a commit
to wpbonelli/flopy
that referenced
this pull request
Dec 14, 2022
wpbonelli
pushed a commit
to wpbonelli/flopy
that referenced
this pull request
Dec 14, 2022
…odflowpy#1583) * Allow write_gridlines_shapefile to write .prj file * Add test_write_gridlines_shapefile * Add remaining file missed from modflowpy#1563 for Mt3dms
wpbonelli
pushed a commit
that referenced
this pull request
Dec 14, 2022
wpbonelli
pushed a commit
to wpbonelli/flopy
that referenced
this pull request
Dec 14, 2022
wpbonelli
pushed a commit
to wpbonelli/flopy
that referenced
this pull request
Dec 14, 2022
…odflowpy#1583) * Allow write_gridlines_shapefile to write .prj file * Add test_write_gridlines_shapefile * Add remaining file missed from modflowpy#1563 for Mt3dms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
.exesuffix from various exe names in the main flopy module and in examples. There are a few reasons for this:.exesuffix unnecessary for Windows, since executables are defined as any file with suffixes listed inPATHEXT. Callingmf2005in Windows will automatically findmf2005.EXEif it is in one of the folders from thePATHenvironment variable.loadmethods to have defaults (e.g.)exe_name="mf2005.exe"that imply they are designed only for Windows, when these same classes and methods work cross-platform for Linux and macOS too.Note that these changes should not break anything downstream, e.g. someone with a script with
exe_name="mf2005.exe"will still continue to work on Linux/macOS (mbase.py will remove.exeif the executable is not found).Other changes:
BaseModel.exe_namefrommf2k.exetomf2005, although this is an abstract base class, so this modification does not change anything.import platformstatements where the module is not used.