fix(csvfile): correction to read_csv args, close file handle #1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1590 +/- ##
=======================================
Coverage 72.6% 72.6%
=======================================
Files 251 251
Lines 54419 54419
=======================================
Hits 39553 39553
Misses 14866 14866
|
|
Doh. Thanks for the fix! |
langevin-usgs
approved these changes
Oct 16, 2022
wpbonelli
pushed a commit
to wpbonelli/flopy
that referenced
this pull request
Dec 14, 2022
wpbonelli
pushed a commit
to wpbonelli/flopy
that referenced
this pull request
Dec 14, 2022
wpbonelli
pushed a commit
that referenced
this pull request
Dec 14, 2022
wpbonelli
pushed a commit
to wpbonelli/flopy
that referenced
this pull request
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an argument mix-up with CsvFile (from #1587), where
deletecharswas passed asreplace_space, andreplace_spacewas never passed tonp.genfromtxt.Also, use a context manager to open/read/close file, as it does not need to be open any longer.