Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(shapefile_utils): remove deprecated SpatialReference usages #1892

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

wpbonelli
Copy link
Member

@wpbonelli wpbonelli commented Aug 1, 2023

  • deprecated 3.3.1 (June 2020)
  • remove unused URL

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #1892 (10cf1c4) into develop (70b9a37) will decrease coverage by 1.8%.
The diff coverage is 100.0%.

@@            Coverage Diff            @@
##           develop   #1892     +/-   ##
=========================================
- Coverage     72.2%   70.5%   -1.8%     
=========================================
  Files          257     257             
  Lines        56488   56480      -8     
=========================================
- Hits         40836   39827   -1009     
- Misses       15652   16653   +1001     
Files Changed Coverage Δ
flopy/export/shapefile_utils.py 83.6% <100.0%> (+1.1%) ⬆️

... and 55 files with indirect coverage changes

@wpbonelli wpbonelli marked this pull request as ready for review August 1, 2023 20:37
@wpbonelli wpbonelli merged commit 6f2da88 into modflowpy:develop Aug 3, 2023
@wpbonelli wpbonelli deleted the shapefileutils-deprecations branch August 3, 2023 13:19
wpbonelli added a commit to wpbonelli/flopy that referenced this pull request Nov 18, 2024
The deprecated module contains spatial reference classes similar to those deprecated/removed in modflowpy#1914, modflowpy#1892, and modflowpy#1200. These are not in use anywhere in the codebase. The flopy.discretization module can be used instead.
wpbonelli added a commit that referenced this pull request Nov 19, 2024
…2375)

The flopy.mf6.utils.reference module contains spatial reference classes similar to those deprecated/removed in #1914#1892, and #1200. These are not in use anywhere in the codebase. The flopy.discretization module can/should be used instead.

---------

Co-authored-by: Mike Taves <mwtoews@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants