refactor(modflow): remove deprecated UZF option, disallow USG #1893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* nwt_11_fmt from mfuzf1.py, 3.3.1 (June 2020) * raise ValueError if ml.version is mfusg in mf.py, 3.3.4 (August 2021)
Codecov Report
@@ Coverage Diff @@
## develop #1893 +/- ##
=======================================
Coverage 72.2% 72.3%
=======================================
Files 257 257
Lines 56488 56473 -15
=======================================
- Hits 40836 40833 -3
+ Misses 15652 15640 -12
|
|
Hey @jlarsen-usgs, can you have a quick look at this removal of the |
langevin-usgs
approved these changes
Aug 3, 2023
|
@jlarsen-usgs could you take a look at this? |
jlarsen-usgs
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nwt_11_fmtparameter/logic frommfuzf1.py, deprecated 3.3.1 (June 2020)ValueErrorifml.versionis "mfusg" inmf.py, deprecated 3.3.4 (August 2021)