Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dependencies): remove python-dateutil #2080

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

wpbonelli
Copy link
Member

@wpbonelli wpbonelli commented Feb 1, 2024

  • python-dateutil is already required by pandas, don't need to list it explicitly
  • prevents optional dependency CI testing failures like this

@wpbonelli wpbonelli changed the title deps refactor(dependencies): remove python-dateutil Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d0c5dbc) 73.0% compared to head (a2d4058) 73.0%.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #2080   +/-   ##
=======================================
  Coverage     73.0%   73.0%           
=======================================
  Files          259     259           
  Lines        59329   59329           
=======================================
+ Hits         43316   43331   +15     
+ Misses       16013   15998   -15     

see 6 files with indirect coverage changes

@wpbonelli wpbonelli merged commit da8a3bd into modflowpy:develop Feb 1, 2024
24 checks passed
@wpbonelli wpbonelli deleted the deps branch February 1, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant