-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(masked_4D_arrays): allow re-use of preceding spd data if empty #2314
fix(masked_4D_arrays): allow re-use of preceding spd data if empty #2314
Conversation
98bca51
to
b8a8cac
Compare
At least some of the CI failures look like the same thing Josh is running into #2318 (comment). I will patch the get-modflow script shortly |
…eding spd data if empty (mf6)
…ements are of object type
…heck transientlist
b8a8cac
to
fe21cbd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2314 +/- ##
=========================================
- Coverage 74.3% 74.2% -0.1%
=========================================
Files 294 292 -2
Lines 59562 59683 +121
=========================================
+ Hits 44282 44336 +54
- Misses 15280 15347 +67
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this @martclanor
This PR aims to address the issue raised in discussion #2309
I did remove the bare except clause in
flopy.export.shapefile_utils.model_attributes_to_shapefile
but it caused several tests to fail. These issues were addressed in the last commits. However, in hindsight, I'm not sure if that was worth removing.