Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Modpath7.create_mp7): expose porosity parameter of Modpath7Bas #2340

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

martclanor
Copy link
Contributor

This PR exposes the porosity parameter of Modpath7Bas in Modpath7's convenience method, create_mp7. This idea is raised in #2339.

Copy link

codecov bot commented Oct 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.9%. Comparing base (5555d15) to head (5a82635).
Report is 12 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #2340     +/-   ##
=========================================
- Coverage     74.3%   73.9%   -0.5%     
=========================================
  Files          294     292      -2     
  Lines        59562   59715    +153     
=========================================
- Hits         44282   44142    -140     
- Misses       15280   15573    +293     
Files with missing lines Coverage Δ
flopy/modpath/mp7.py 86.5% <100.0%> (ø)

... and 25 files with indirect coverage changes

@martclanor martclanor marked this pull request as ready for review October 20, 2024 12:29
@wpbonelli wpbonelli merged commit 3a2c494 into modflowpy:develop Oct 20, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants