Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support python 3.13 #2341

Merged
merged 2 commits into from
Oct 23, 2024
Merged

chore: support python 3.13 #2341

merged 2 commits into from
Oct 23, 2024

Conversation

mwtoews
Copy link
Contributor

@mwtoews mwtoews commented Oct 21, 2024

Python 3.13 was recently released, which works fine with most of flopy's functionality.

Only VTK (and PyVista) does not yet support Python 3.13 from PyPI, as specified with conditional expressions. All package combinations for Python 3.13 are available for conda-forge.

@mwtoews mwtoews changed the title chore: support and test python 3.13 chore: support python 3.13 Oct 21, 2024
@mwtoews
Copy link
Contributor Author

mwtoews commented Oct 21, 2024

Further checks with conda-forge reveal that not all packages have yet been built for Python 3.13. For instance, shapely and pymetis are not yet available. Thus testing has been removed for now. For reference, use this doc to try and install Python and packages for 3.13.

Nevertheless, local testing on linux works with this PR for PyPI using pip install -e .[test,optional] which installs everything except VTK and PyVista.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.2%. Comparing base (332a310) to head (ffed180).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #2341     +/-   ##
=========================================
- Coverage     74.2%   74.2%   -0.1%     
=========================================
  Files          292     292             
  Lines        59685   59685             
=========================================
- Hits         44335   44334      -1     
- Misses       15350   15351      +1     

see 7 files with indirect coverage changes

@wpbonelli
Copy link
Member

wpbonelli commented Oct 21, 2024

I thought we were out of the woods w.r.t. to the recent micromamba/windows issue but evidently not. I will merge anyway.

@wpbonelli wpbonelli merged commit 370efbf into modflowpy:develop Oct 23, 2024
18 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants