Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: resolve ruff check F821 for undefined name #2374

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

mwtoews
Copy link
Contributor

@mwtoews mwtoews commented Nov 17, 2024

This is a minor refactor to resolve F821 for undefined name.

As with other checks, "flopy/mf6/**/*.py" is ignored (which currently has several F821 issues).

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.9%. Comparing base (bb9824e) to head (54a2622).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #2374     +/-   ##
=========================================
+ Coverage     68.4%   75.9%   +7.5%     
=========================================
  Files          294     294             
  Lines        59390   61638   +2248     
=========================================
+ Hits         40652   46841   +6189     
+ Misses       18738   14797   -3941     

see 229 files with indirect coverage changes

---- 🚨 Try these New Features:

@wpbonelli wpbonelli merged commit 373b82d into modflowpy:develop Nov 18, 2024
23 checks passed
@mwtoews mwtoews deleted the fix-F821 branch November 18, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants