Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused setup.py wrapper #2386

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

mwtoews
Copy link
Contributor

@mwtoews mwtoews commented Dec 1, 2024

The setup.py file was converted to a setuptools wrapper with #1678. This file is not used in this project, and modern pip/setuptools don't look for it anymore, so it can be cleaned up.

Copy link

codecov bot commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.2%. Comparing base (bb9824e) to head (8a6c2c9).
Report is 15 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #2386     +/-   ##
=========================================
+ Coverage     68.4%   76.2%   +7.8%     
=========================================
  Files          294     293      -1     
  Lines        59390   59648    +258     
=========================================
+ Hits         40652   45501   +4849     
+ Misses       18738   14147   -4591     

see 232 files with indirect coverage changes

@wpbonelli wpbonelli merged commit 11d9b7f into modflowpy:develop Dec 2, 2024
23 checks passed
@mwtoews mwtoews deleted the rm-setup-py branch December 2, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants