Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mf6: update dfns and mf6 module #2399

Merged
merged 3 commits into from
Dec 20, 2024
Merged

mf6: update dfns and mf6 module #2399

merged 3 commits into from
Dec 20, 2024

Conversation

wpbonelli
Copy link
Member

@wpbonelli wpbonelli commented Dec 20, 2024

Add dfns and generate mf6 module for compatibility with new mf6. Leave out surface water models.

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 97.26027% with 14 lines in your changes missing coverage. Please review.

Project coverage is 76.4%. Comparing base (bb9824e) to head (12d3670).
Report is 21 commits behind head on develop.

Files with missing lines Patch % Lines
flopy/mf6/modflow/mfgwedisv.py 58.3% 5 Missing ⚠️
flopy/mf6/modflow/mfgwedisu.py 86.6% 2 Missing ⚠️
flopy/mf6/modflow/mfgwemve.py 80.0% 2 Missing ⚠️
flopy/mf6/modflow/mfgwfgnc.py 71.4% 2 Missing ⚠️
flopy/mf6/modflow/mfgwfmvr.py 83.3% 2 Missing ⚠️
flopy/mf6/modflow/mfgnc.py 85.7% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #2399     +/-   ##
=========================================
+ Coverage     68.4%   76.4%   +7.9%     
=========================================
  Files          294     294             
  Lines        59390   59704    +314     
=========================================
+ Hits         40652   45619   +4967     
+ Misses       18738   14085   -4653     
Files with missing lines Coverage Δ
flopy/mf6/modflow/__init__.py 100.0% <100.0%> (ø)
flopy/mf6/modflow/mfems.py 100.0% <100.0%> (+22.2%) ⬆️
flopy/mf6/modflow/mfgwe.py 100.0% <100.0%> (+58.8%) ⬆️
flopy/mf6/modflow/mfgweadv.py 100.0% <100.0%> (+30.0%) ⬆️
flopy/mf6/modflow/mfgwecnd.py 100.0% <100.0%> (+44.4%) ⬆️
flopy/mf6/modflow/mfgwectp.py 100.0% <100.0%> (+53.8%) ⬆️
flopy/mf6/modflow/mfgwedis.py 100.0% <100.0%> (+55.1%) ⬆️
flopy/mf6/modflow/mfgweesl.py 100.0% <100.0%> (+53.8%) ⬆️
flopy/mf6/modflow/mfgweest.py 100.0% <100.0%> (+43.4%) ⬆️
flopy/mf6/modflow/mfgwefmi.py 100.0% <100.0%> (+35.7%) ⬆️
... and 95 more

... and 147 files with indirect coverage changes

@wpbonelli wpbonelli merged commit 4952f81 into modflowpy:develop Dec 20, 2024
23 checks passed
@wpbonelli wpbonelli deleted the mf6 branch December 20, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants