Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): cleanup _get_optlevel verbose param #199

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

mjreno
Copy link
Contributor

@mjreno mjreno commented Nov 22, 2024

No description provided.

@mjreno mjreno changed the title fix(utils): cleanup _get_optlevel verbose param in pymake_base fix(utils): cleanup _get_optlevel verbose param Nov 22, 2024
@mjreno mjreno requested a review from mwtoews November 22, 2024 18:55
Copy link
Member

@wpbonelli wpbonelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this. thanks @mjreno

@wpbonelli wpbonelli merged commit feb8adf into modflowpy:develop Nov 22, 2024
1 check passed
wpbonelli pushed a commit that referenced this pull request Nov 29, 2024
…ules (#200)

Refactor a few semi-related aspects:

- Revise strings and whitespace using a few methods with Ruff and manual edits
- Revise a few aspects of pathlib.Path -- these changes are added here to shorten some string formatting, but remain consistent throughout the code base
- Fix one more instance of removed verbose parameter in _get_optlevel(), similar to #199
- Apply Ruff pyupgrade (UP) rules
- Apply Ruff section-underline-matches-section-length (D409) rule
- Apply Ruff-specific rules (RUF)
jdhughes-usgs added a commit that referenced this pull request Dec 20, 2024
* ci(release): update version to 1.2.11.dev0

* ci: fix schedule for windows (#193)

* fix(requests): update available assets (#194)

Add macarm.zip asset

* chore: reformat Python code with line length = 88 (#198)

Reformat the code with a maximum line length of 88 characters to better represent the code.

See modflowpy/flopy#2362 for a related PR with rational and discussion.

Also change some of Ruff's configuration:

- Remove target-version, since it is automatically evaluated from pyproject.toml
- Remove include so that Ruff will work globally in this repo

* fix: cleanup _get_optlevel verbose param in pymake_base (#199)

Co-authored-by: mjreno <mjreno@IGSAAA071L01144.gs.doi.net>

* refactor: clean-up strings and Path related aspects, add a few Ruff rules (#200)

Refactor a few semi-related aspects:

- Revise strings and whitespace using a few methods with Ruff and manual edits
- Revise a few aspects of pathlib.Path -- these changes are added here to shorten some string formatting, but remain consistent throughout the code base
- Fix one more instance of removed verbose parameter in _get_optlevel(), similar to #199
- Apply Ruff pyupgrade (UP) rules
- Apply Ruff section-underline-matches-section-length (D409) rule
- Apply Ruff-specific rules (RUF)

* build(deps): bump dawidd6/action-download-artifact from 6 to 7 (#201)

* update for mf6.6.0 (#203)

* fix fortran submodule evaluation 
* update sutra and mfusg_gsi versions.
* update pixi version

* ci(release): set version to 1.3.0

---------

Co-authored-by: wpbonelli <wbonelli@ucar.edu>
Co-authored-by: jdhughes-usgs <jdhughes@usgs.gov>
Co-authored-by: Mike Taves <mwtoews@gmail.com>
Co-authored-by: mjreno <renomik@gmail.com>
Co-authored-by: mjreno <mjreno@IGSAAA071L01144.gs.doi.net>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jdhughes-usgs added a commit that referenced this pull request Dec 20, 2024
* ci(release): update version to 1.2.11.dev0

* ci: fix schedule for windows (#193)

* fix(requests): update available assets (#194)

Add macarm.zip asset

* chore: reformat Python code with line length = 88 (#198)

Reformat the code with a maximum line length of 88 characters to better represent the code.

See modflowpy/flopy#2362 for a related PR with rational and discussion.

Also change some of Ruff's configuration:

- Remove target-version, since it is automatically evaluated from pyproject.toml
- Remove include so that Ruff will work globally in this repo

* fix: cleanup _get_optlevel verbose param in pymake_base (#199)

Co-authored-by: mjreno <mjreno@IGSAAA071L01144.gs.doi.net>

* refactor: clean-up strings and Path related aspects, add a few Ruff rules (#200)

Refactor a few semi-related aspects:

- Revise strings and whitespace using a few methods with Ruff and manual edits
- Revise a few aspects of pathlib.Path -- these changes are added here to shorten some string formatting, but remain consistent throughout the code base
- Fix one more instance of removed verbose parameter in _get_optlevel(), similar to #199
- Apply Ruff pyupgrade (UP) rules
- Apply Ruff section-underline-matches-section-length (D409) rule
- Apply Ruff-specific rules (RUF)

* build(deps): bump dawidd6/action-download-artifact from 6 to 7 (#201)

* update for mf6.6.0 (#203)

* fix fortran submodule evaluation 
* update sutra and mfusg_gsi versions.
* update pixi version

* ci: fix release code.md path (#205)

* ci(release): set version to 1.3.0

---------

Co-authored-by: wpbonelli <wbonelli@ucar.edu>
Co-authored-by: jdhughes-usgs <jdhughes@usgs.gov>
Co-authored-by: Mike Taves <mwtoews@gmail.com>
Co-authored-by: mjreno <renomik@gmail.com>
Co-authored-by: mjreno <mjreno@IGSAAA071L01144.gs.doi.net>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants