-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(utils): cleanup _get_optlevel verbose param #199
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjreno
changed the title
fix(utils): cleanup _get_optlevel verbose param in pymake_base
fix(utils): cleanup _get_optlevel verbose param
Nov 22, 2024
wpbonelli
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed this. thanks @mjreno
wpbonelli
pushed a commit
that referenced
this pull request
Nov 29, 2024
…ules (#200) Refactor a few semi-related aspects: - Revise strings and whitespace using a few methods with Ruff and manual edits - Revise a few aspects of pathlib.Path -- these changes are added here to shorten some string formatting, but remain consistent throughout the code base - Fix one more instance of removed verbose parameter in _get_optlevel(), similar to #199 - Apply Ruff pyupgrade (UP) rules - Apply Ruff section-underline-matches-section-length (D409) rule - Apply Ruff-specific rules (RUF)
jdhughes-usgs
added a commit
that referenced
this pull request
Dec 20, 2024
* ci(release): update version to 1.2.11.dev0 * ci: fix schedule for windows (#193) * fix(requests): update available assets (#194) Add macarm.zip asset * chore: reformat Python code with line length = 88 (#198) Reformat the code with a maximum line length of 88 characters to better represent the code. See modflowpy/flopy#2362 for a related PR with rational and discussion. Also change some of Ruff's configuration: - Remove target-version, since it is automatically evaluated from pyproject.toml - Remove include so that Ruff will work globally in this repo * fix: cleanup _get_optlevel verbose param in pymake_base (#199) Co-authored-by: mjreno <mjreno@IGSAAA071L01144.gs.doi.net> * refactor: clean-up strings and Path related aspects, add a few Ruff rules (#200) Refactor a few semi-related aspects: - Revise strings and whitespace using a few methods with Ruff and manual edits - Revise a few aspects of pathlib.Path -- these changes are added here to shorten some string formatting, but remain consistent throughout the code base - Fix one more instance of removed verbose parameter in _get_optlevel(), similar to #199 - Apply Ruff pyupgrade (UP) rules - Apply Ruff section-underline-matches-section-length (D409) rule - Apply Ruff-specific rules (RUF) * build(deps): bump dawidd6/action-download-artifact from 6 to 7 (#201) * update for mf6.6.0 (#203) * fix fortran submodule evaluation * update sutra and mfusg_gsi versions. * update pixi version * ci(release): set version to 1.3.0 --------- Co-authored-by: wpbonelli <wbonelli@ucar.edu> Co-authored-by: jdhughes-usgs <jdhughes@usgs.gov> Co-authored-by: Mike Taves <mwtoews@gmail.com> Co-authored-by: mjreno <renomik@gmail.com> Co-authored-by: mjreno <mjreno@IGSAAA071L01144.gs.doi.net> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jdhughes-usgs
added a commit
that referenced
this pull request
Dec 20, 2024
* ci(release): update version to 1.2.11.dev0 * ci: fix schedule for windows (#193) * fix(requests): update available assets (#194) Add macarm.zip asset * chore: reformat Python code with line length = 88 (#198) Reformat the code with a maximum line length of 88 characters to better represent the code. See modflowpy/flopy#2362 for a related PR with rational and discussion. Also change some of Ruff's configuration: - Remove target-version, since it is automatically evaluated from pyproject.toml - Remove include so that Ruff will work globally in this repo * fix: cleanup _get_optlevel verbose param in pymake_base (#199) Co-authored-by: mjreno <mjreno@IGSAAA071L01144.gs.doi.net> * refactor: clean-up strings and Path related aspects, add a few Ruff rules (#200) Refactor a few semi-related aspects: - Revise strings and whitespace using a few methods with Ruff and manual edits - Revise a few aspects of pathlib.Path -- these changes are added here to shorten some string formatting, but remain consistent throughout the code base - Fix one more instance of removed verbose parameter in _get_optlevel(), similar to #199 - Apply Ruff pyupgrade (UP) rules - Apply Ruff section-underline-matches-section-length (D409) rule - Apply Ruff-specific rules (RUF) * build(deps): bump dawidd6/action-download-artifact from 6 to 7 (#201) * update for mf6.6.0 (#203) * fix fortran submodule evaluation * update sutra and mfusg_gsi versions. * update pixi version * ci: fix release code.md path (#205) * ci(release): set version to 1.3.0 --------- Co-authored-by: wpbonelli <wbonelli@ucar.edu> Co-authored-by: jdhughes-usgs <jdhughes@usgs.gov> Co-authored-by: Mike Taves <mwtoews@gmail.com> Co-authored-by: mjreno <renomik@gmail.com> Co-authored-by: mjreno <mjreno@IGSAAA071L01144.gs.doi.net> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.