Skip to content

Commit

Permalink
fixes
Browse files Browse the repository at this point in the history
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
  • Loading branch information
anmyachev committed Mar 1, 2024
1 parent 27e1444 commit 0e7e206
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
13 changes: 8 additions & 5 deletions modin/pandas/test/dataframe/test_map_metadata.py
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,8 @@ def test_astype_errors(errors):
modin_df, pandas_df = create_test_dfs(data)
raising_exceptions = None
if errors == "raise":
raising_exceptions = ValueError("invalid literal for int() with base 10: 'a'")
# FIXME: different messages
raising_exceptions = False
eval_general(
modin_df,
pandas_df,
Expand Down Expand Up @@ -1294,9 +1295,8 @@ def test_insert_dtypes(data, astype, request):

raising_exceptions = None
if "int32-float_nan_data" in request.node.callspec.id:
raising_exceptions = pandas.errors.IntCastingNaNError(
"Cannot convert non-finite values (NA or inf) to integer"
)
# FIXME: different messages
raising_exceptions = False
eval_insert(
modin_df,
pandas_df,
Expand Down Expand Up @@ -1621,7 +1621,9 @@ def test_transpose(data):
def test_update(data, other_data, errors):
modin_df, pandas_df = create_test_dfs(data)
other_modin_df, other_pandas_df = create_test_dfs(other_data)

raising_exceptions = None
if errors == "raise":
raising_exceptions = ValueError("Data overlaps.")
eval_general(
modin_df,
pandas_df,
Expand All @@ -1631,6 +1633,7 @@ def test_update(data, other_data, errors):
else df.update(other_pandas_df, errors=errors)
),
__inplace__=True,
raising_exceptions=raising_exceptions,
)


Expand Down
1 change: 0 additions & 1 deletion modin/pandas/test/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -916,7 +916,6 @@ def execute_callable(fn, inplace=False, md_kwargs={}, pd_kwargs={}):
# unwrap ray exceptions from remote worker
if isinstance(modin_exception, RayTaskError):
modin_exception = modin_exception.args[0]
# breakpoint()
assert (
type(modin_exception) is type(raising_exceptions)
and modin_exception.args == raising_exceptions.args
Expand Down

0 comments on commit 0e7e206

Please sign in to comment.