-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of redundant function calls on Ray workers #3599
Comments
…rkers Signed-off-by: Igoshev, Yaroslav <yaroslav.igoshev@intel.com>
Is the issue we're working around really gone?.. If it isn't this is going to hamper the stability a lot (and my impression is the issue in Ray is still there). |
I do not see the issue locally and there is no issue in our CI. Also, there is an issue #3601 where a run of pandas imports on Ray workers seems to be a problem. |
It's most evident on large machines with 100+ CPU cores. I don't trust that the bug is gone in Ray as long as the import thread is separate from the worker thread. I prefer to leave the code as it is. Is there a problem with using these functionalities in Ray? |
I had run Modin tests on a machine with 112 CPU cores and didn't see any fail. Let's wait @rkooo567's answer in #3601 on the status of the problem.
I prefer Modin (and probably other users/packages) used high-level API (link) from Ray and other packages and didn't not rely on their internals. |
I am strongly against removing it. I spent probably 100 hours debugging and trying to get to a solution for the import thread race condition, even when engaging with the Ray team. Yes, it's not ideal to use internal APIs, but it is too important and I have spent too much time on it. It's not something that's even easily reproduced, and as long as Ray chooses to import in a separate thread from running actual code, I do not trust that design for Modin workloads. |
Makes sense. Let's follow the discussion in #3601 for now. |
Hi @YarShev @vnlitvinov @devin-petersohn has this issue been resolved? |
We have had a hacky solution to prevent #3014, #647, #746. We should try to get rid of it since we use Ray functionality that is not directly supposed to be used.
The text was updated successfully, but these errors were encountered: