Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS: Add that commit messages can start with PERF. #4469

Closed
mvashishtha opened this issue May 19, 2022 · 1 comment · Fixed by #4470 or #4475
Closed

DOCS: Add that commit messages can start with PERF. #4469

mvashishtha opened this issue May 19, 2022 · 1 comment · Fixed by #4470 or #4475

Comments

@mvashishtha
Copy link
Collaborator

Right now the docs say that commit messages should start with FEAT, DOCS, FIX, REFACTOR, or TEST. Performance changes don't fit well into any of this labels, so we should add a "PERF" label.
mvashishtha pushed a commit to mvashishtha/modin that referenced this issue May 19, 2022
DOCS-modin-project#4469: Say that commit messages can start with PERF.
291f1b7 
Signed-off-by: mvashishtha <mahesh@ponder.io>
@mvashishtha mvashishtha mentioned this issue May 19, 2022
Merged
8 tasks
YarShev pushed a commit that referenced this issue May 19, 2022
@mvashishtha
DOCS-#4469: Say that commit messages can start with PERF. (#4470)
1ba3778 
Signed-off-by: mvashishtha <mahesh@ponder.io>
@mvashishtha mvashishtha reopened this May 19, 2022
@mvashishtha
Copy link
Collaborator Author

I'm reopening this issue because we need to make the commit lint allow commit messages starting with PERF.

mvashishtha pushed a commit to mvashishtha/modin that referenced this issue May 19, 2022
DOCS-modin-project#4469: Allow commit messages starting with PERF.
0af68e7 
Signed-off-by: mvashishtha <mahesh@ponder.io>
@mvashishtha mvashishtha mentioned this issue May 19, 2022
Merged
8 tasks
YarShev pushed a commit that referenced this issue May 19, 2022
@mvashishtha
DOCS-#4469: Allow commit messages starting with PERF. (#4475)
0f70e82 
Signed-off-by: mvashishtha <mahesh@ponder.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@mvashishtha