Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mypy checks for modin.distributed #4631

Closed
pyrito opened this issue Jul 1, 2022 · 0 comments · Fixed by #5109
Closed

Add mypy checks for modin.distributed #4631

pyrito opened this issue Jul 1, 2022 · 0 comments · Fixed by #5109
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase good first issue 🔰 Good for newcomers hacktoberfest P3 Very minor bugs, or features we can hopefully add some day.

Comments

@pyrito
Copy link
Collaborator

pyrito commented Jul 1, 2022

We need to expand our mypy checks to cover Python files in modin/distributed/. There may be a lot of files to modify at once so folks should focus on type annotations one file at a time. Please make sure to add files to mypy.ini!
@pyrito pyrito added good first issue 🔰 Good for newcomers Code Quality 💯 Improvements or issues to improve quality of codebase labels Jul 1, 2022
@pyrito pyrito added the P3 Very minor bugs, or features we can hopefully add some day. label Aug 31, 2022
@rosdyana rosdyana mentioned this issue Oct 9, 2022
Merged
7 tasks
rosdyana added a commit to rosdyana/modin that referenced this issue Oct 10, 2022
@rosdyana
FIX-modin-project#4631: Add mypy checks for modin.distributed.
e904736 
Signed-off-by: Rosdyana Kusuma <rosdyana.kusuma@gmail.com>
rosdyana added a commit to rosdyana/modin that referenced this issue Oct 11, 2022
@rosdyana
FIX-modin-project#4631: Add mypy checks for modin.distributed.
b04de9e 
Signed-off-by: Rosdyana Kusuma <rosdyana.kusuma@gmail.com>
vnlitvinov pushed a commit that referenced this issue Oct 25, 2022
@rosdyana
REFACTOR-#4631: Add mypy checks for modin.distributed (#5109)
ae465be 
Signed-off-by: Rosdyana Kusuma <rosdyana.kusuma@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase good first issue 🔰 Good for newcomers hacktoberfest P3 Very minor bugs, or features we can hopefully add some day.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

REFACTOR-#4631: Add mypy checks for modin.distributed rosdyana/modin
2 participants
@pyrito @mvashishtha