Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More granular suppression of lint warning F821 undefined name 'name' #4722

Closed
noloerino opened this issue Jul 27, 2022 · 0 comments · Fixed by #4723
Closed

More granular suppression of lint warning F821 undefined name 'name' #4722

noloerino opened this issue Jul 27, 2022 · 0 comments · Fixed by #4723
Assignees
@noloerino
Labels
CI Code Quality 💯 Improvements or issues to improve quality of codebase

Comments

@noloerino
Copy link
Collaborator

noloerino commented Jul 27, 2022 •
edited
Loading

Currently, our flake8 config is set up to suppress F821 undefined name 'name', which triggers when an undefined name is referenced. This seems to be set up in order to ignore a bunch of pandas/omnisci classes that are referenced in types without being imported, such as for BasePandasDataset here.

Full output of the linter on current master (0236358) 
$ flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
modin/experimental/core/execution/native/implementations/omnisci_on_native/exchange/dataframe_protocol/dataframe.py:191:52: F821 undefined name 'is_range_like'
modin/experimental/core/execution/native/implementations/omnisci_on_native/exchange/dataframe_protocol/column.py:62:32: F821 undefined name 'OmnisciProtocolDataframe'
modin/experimental/core/execution/native/implementations/omnisci_on_native/exchange/dataframe_protocol/column.py:257:70: F821 undefined name 'Column'
modin/experimental/core/execution/native/implementations/omnisci_on_native/dataframe/dataframe.py:2080:33: F821 undefined name 'ProtocolDataframe'
modin/core/dataframe/pandas/dataframe/dataframe.py:2930:33: F821 undefined name 'ProtocolDataframe'
modin/_compat/pandas_api/py36/io.py:301:25: F821 undefined name 'FilePathOrBuffer'
modin/_compat/pandas_api/py36/series.py:129:38: F821 undefined name 'DataFrame'
modin/_compat/pandas_api/latest/dataframe.py:158:17: F821 undefined name 'NoDefault'
modin/_compat/pandas_api/latest/dataframe.py:216:15: F821 undefined name 'FilePath'
modin/_compat/pandas_api/latest/dataframe.py:216:15: F821 undefined name 'WriteBuffer'
modin/_compat/pandas_api/latest/dataframe.py:217:24: F821 undefined name 'Hashable'
modin/_compat/pandas_api/latest/dataframe.py:220:21: F821 undefined name 'datetime'
modin/_compat/pandas_api/latest/dataframe.py:222:26: F821 undefined name 'Hashable'
modin/_compat/pandas_api/latest/dataframe.py:224:23: F821 undefined name 'Sequence'
modin/_compat/pandas_api/latest/dataframe.py:224:23: F821 undefined name 'Hashable'
modin/_compat/pandas_api/latest/dataframe.py:225:22: F821 undefined name 'CompressionOptions'
modin/_compat/pandas_api/latest/dataframe.py:228:23: F821 undefined name 'Hashable'
modin/_compat/pandas_api/latest/io.py:66:25: F821 undefined name 'FilePath'
modin/_compat/pandas_api/latest/io.py:66:25: F821 undefined name 'ReadCsvBuffer'
modin/_compat/pandas_api/latest/io.py:66:25: F821 undefined name 'ReadCsvBuffer'
modin/_compat/pandas_api/latest/io.py:76:12: F821 undefined name 'DtypeArg'
modin/_compat/pandas_api/latest/io.py:77:13: F821 undefined name 'CSVEngine'
modin/_compat/pandas_api/latest/io.py:97:18: F821 undefined name 'CompressionOptions'
modin/_compat/pandas_api/latest/io.py:117:22: F821 undefined name 'StorageOptions'
modin/_compat/pandas_api/latest/io.py:131:25: F821 undefined name 'FilePath'
modin/_compat/pandas_api/latest/io.py:131:25: F821 undefined name 'ReadCsvBuffer'
modin/_compat/pandas_api/latest/io.py:131:25: F821 undefined name 'ReadCsvBuffer'
modin/_compat/pandas_api/latest/io.py:141:12: F821 undefined name 'DtypeArg'
modin/_compat/pandas_api/latest/io.py:142:13: F821 undefined name 'CSVEngine'
modin/_compat/pandas_api/latest/io.py:163:18: F821 undefined name 'CompressionOptions'
modin/_compat/pandas_api/latest/io.py:182:22: F821 undefined name 'StorageOptions'
modin/_compat/pandas_api/latest/io.py:201:22: F821 undefined name 'StorageOptions'
modin/_compat/pandas_api/latest/io.py:239:22: F821 undefined name 'StorageOptions'
modin/_compat/pandas_api/latest/io.py:279:17: F821 undefined name 'IntStrT'
modin/_compat/pandas_api/latest/io.py:280:13: F821 undefined name 'Sequence'
modin/_compat/pandas_api/latest/io.py:282:16: F821 undefined name 'Sequence'
modin/_compat/pandas_api/latest/io.py:285:12: F821 undefined name 'DtypeArg'
modin/_compat/pandas_api/latest/io.py:286:13: F821 undefined name 'Literal'
modin/_compat/pandas_api/latest/io.py:288:18: F821 undefined name 'Iterable'
modin/_compat/pandas_api/latest/io.py:288:18: F821 undefined name 'Hashable'
modin/_compat/pandas_api/latest/io.py:289:19: F821 undefined name 'Iterable'
modin/_compat/pandas_api/latest/io.py:289:19: F821 undefined name 'Hashable'
modin/_compat/pandas_api/latest/io.py:290:15: F821 undefined name 'Sequence'
modin/_compat/pandas_api/latest/io.py:290:15: F821 undefined name 'Callable'
modin/_compat/pandas_api/latest/io.py:304:22: F821 undefined name 'StorageOptions'
modin/_compat/pandas_api/latest/io.py:305:6: F821 undefined name 'IntStrT'
modin/_compat/pandas_api/latest/io.py:327:22: F821 undefined name 'StorageOptions'
modin/_compat/pandas_api/latest/io.py:351:22: F821 undefined name 'StorageOptions'
modin/_compat/pandas_api/latest/io.py:366:22: F821 undefined name 'StorageOptions'
modin/_compat/pandas_api/latest/io.py:401:18: F821 undefined name 'CompressionOptions'
modin/_compat/pandas_api/latest/io.py:403:22: F821 undefined name 'StorageOptions'
modin/_compat/pandas_api/latest/series.py:36:14: F821 undefined name 'IO'
modin/_compat/pandas_api/latest/series.py:52:15: F821 undefined name 'Axis'
modin/_compat/pandas_api/latest/series.py:52:15: F821 undefined name 'NoDefault'
modin/_compat/pandas_api/latest/series.py:112:17: F821 undefined name 'NoDefault'
modin/_compat/pandas_api/latest/series.py:148:21: F821 undefined name 'Hashable'
modin/_compat/pandas_api/latest/series.py:149:10: F821 undefined name 'DataFrame'
modin/_compat/pandas_api/latest/utils.py:36:15: F821 undefined name 'NoDefault'
modin/_compat/pandas_api/latest/base.py:42:15: F821 undefined name 'BasePandasDataset'
modin/_compat/pandas_api/latest/base.py:45:24: F821 undefined name 'bool_t'
modin/_compat/pandas_api/latest/base.py:45:24: F821 undefined name 'NoDefault'
modin/_compat/pandas_api/latest/base.py:46:22: F821 undefined name 'bool_t'
modin/_compat/pandas_api/latest/base.py:46:22: F821 undefined name 'NoDefault'
modin/_compat/pandas_api/latest/base.py:90:19: F821 undefined name 'TimedeltaConvertibleTypes'
modin/_compat/pandas_api/latest/base.py:93:17: F821 undefined name 'bool_t'
modin/_compat/pandas_api/latest/base.py:94:20: F821 undefined name 'bool_t'
modin/_compat/pandas_api/latest/base.py:95:15: F821 undefined name 'Axis'
modin/_compat/pandas_api/latest/base.py:96:16: F821 undefined name 'np'
modin/_compat/pandas_api/latest/base.py:96:16: F821 undefined name 'BasePandasDataset'
modin/_compat/pandas_api/latest/base.py:98:10: F821 undefined name 'ExponentialMovingWindow'
modin/_compat/pandas_api/latest/base.py:119:15: F821 undefined name 'Axis'
modin/_compat/pandas_api/latest/base.py:119:15: F821 undefined name 'NoDefault'
modin/_compat/pandas_api/latest/base.py:156:15: F821 undefined name 'NoDefault'
modin/_compat/pandas_api/latest/base.py:168:15: F821 undefined name 'NoDefault'
modin/_compat/pandas_api/latest/base.py:182:15: F821 undefined name 'BasePandasDataset'
modin/_compat/pandas_api/latest/base.py:185:23: F821 undefined name 'bool_t'
modin/_compat/pandas_api/latest/base.py:185:23: F821 undefined name 'NoDefault'
modin/_compat/pandas_api/latest/base.py:187:20: F821 undefined name 'bool_t'
modin/_compat/pandas_api/latest/base.py:188:14: F821 undefined name 'bool_t'
modin/_compat/pandas_api/latest/base.py:297:15: F821 undefined name 'NoDefault'
modin/pandas/series.py:1847:31: F821 undefined name 'Hashable'
modin/pandas/series.py:1847:46: F821 undefined name 'DataFrame'
@noloerino noloerino added the Code Quality 💯 Improvements or issues to improve quality of codebase label Jul 27, 2022
@noloerino noloerino self-assigned this Jul 27, 2022
@mvashishtha mvashishtha added the CI label Jul 27, 2022
@noloerino noloerino mentioned this issue Jul 27, 2022
Merged
8 tasks
noloerino added a commit to noloerino/modin that referenced this issue Aug 1, 2022
@noloerino
REFACTOR-modin-project#4722: Stop suppressing undefined name lint
c0c78b4 
Signed-off-by: Jonathan Shi <jhshi@ponder.io>
vnlitvinov pushed a commit that referenced this issue Aug 9, 2022
@noloerino
REFACTOR-#4722: Stop suppressing undefined name lint (#4723)
3e981ba 
Signed-off-by: Jonathan Shi <jhshi@ponder.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noloerino noloerino

Labels
CI Code Quality 💯 Improvements or issues to improve quality of codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

REFACTOR-#4722: Stop suppressing undefined name lint noloerino/modin
2 participants
@mvashishtha @noloerino